qt5.qtwebengine: fix build with Ninja 1.12#315787
Merged
K900 merged 1 commit intoNixOS:stagingfrom May 30, 2024
Merged
Conversation
reckenrode
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
as code owners
github-actions
bot
added
the
6.topic: qt/kde
ofborg
bot
added
10.rebuild-darwin: 11-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I ran into this while working on my cctools/cross/clang18 branch, which is rebased on staging regularly. It appears the Ninja upgrade in #303416 broke the Qt WebEngine build. I believe this affects the Qt 6 version as well, but it should be fixed upstream in 6.71. (Unfortunately, Qt WebEngine 6 fails to build on Darwin for other reasons, so I can’t test it.)
Targeting staging because I assume there will still be quite a few Linux rebuilds.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.