ghidra-extensions.ret-sync: init at unstable-2024-05-29

[vringar]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[vringar]

In addition to installing the extension, it also has to be enabled on a per project level but idk where to document that.

[vringar]

@NixOS/nixpkgs-merge-bot merge

[nixpkgs-merge-bot]

@vringar merge not permitted (#305350):
pkgs/tools/security/ghidra/extensions.nix is not in pkgs/by-name/
pkgs/tools/security/ghidra/extensions/ret-sync/default.nix is not in pkgs/by-name/

[vringar]

Sorry for requesting you review even though you clearly stated that you didn't want to be a maintainer. I was just hoping that you might have some input on how to make this PR auto-mergeable.
I have a couple of other extensions that I would like to land in the future and thought I could do so independently, but I guess since they are new packages that doesn't work (? assumption on my part). Should I wait for all of them to be ready and get them landed as one PR?

[Mic92]

I don't think we will allow new packages to be auto-mergeable ever because we need to know about the maintainer before we can allow a package to be merged.

[Mic92]

I used ghidra but never with extension. How can I test this?

[vringar]

We expose the ghidra.withExtensions function that builds Ghidra and all selected plugins and links them together.
The buildGhidraExtension also always adds me as a maintainer, so that guarantees that all new extensions will have a maintainer.

[emilytrau]

Thanks for your work!

[vringar]

Just ran nixpkgs-review pr 315672 and realized that this PR requires #329272 as the build script in its current form is not very usable

[vringar]

PR is mergable again

[emilytrau]

I've pushed up some changes

• Got these extensions to build on darwin with some compatibility changes to buildGhidraExtension
• Removed use of mitmCache as these extensions do not need to download dependencies

Thanks again, hope to have this merged soon :)