Closed
Conversation
This ports the functionality of the C++ nixos-option to a nix script (with a tiny shellscript for argument processing and invoking the nix script). Benefits compared to the native binary include no longer being tied to a specific nix version, generally improved maintainability and improved stability. The main tradeoff is that the C++ version would have better access to introspecting and reporting errors nicely, but that doesn't seem to have been the case in practice anyway. The other tradeoff is that we generate all the output at the end instead of streaming it as we traverse the option tree.
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Drive-by thought: I definitely agree that using nix-instantiate or similar as opposed to using nix as a library is the right move here. |
Member
|
I've amended your commit to the original PR https://github.com/NixOS/nixpkgs/pull/313497/commits. Thanks! |
Member
|
Also would you mind becoming the maintainer of nixos-option? |
Contributor
Author
I'd like to become the maintainer of nixos-option, thanks for the offering. |
Member
|
Added! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Need #313497, tested with:
Fixes #97855
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.