cabal-install: Fix for justStaticExecutables#315460
Closed
9999years wants to merge 1 commit intoNixOS:haskell-updatesfrom
Closed
cabal-install: Fix for justStaticExecutables#3154609999years wants to merge 1 commit intoNixOS:haskell-updatesfrom
9999years wants to merge 1 commit intoNixOS:haskell-updatesfrom
Conversation
9999years
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 11-100
Fixes `cabal-install` to remove references to GHC, mostly through other libraries that are included in the binary. See: NixOS#304352
9999years
force-pushed
the
fix-cabal-instal-darwin
branch
from
49e4033 to
2eef4ba
Compare
9999years
commented
May 29, 2024
Comment on lines
+59
to
+69
| cabal-install = | ||
| let cabal-install = super.cabal-install.overrideScope cabalInstallOverlay; | ||
| scope = cabal-install.scope; | ||
| in overrideCabal (old: { | ||
| postInstall = '' | ||
| ${old.postInstall or ""} | ||
| remove-references-to -t ${scope.ghc} "$out/bin/.cabal-wrapped" | ||
| remove-references-to -t ${scope.HTTP} "$out/bin/.cabal-wrapped" | ||
| remove-references-to -t ${scope.Cabal} "$out/bin/.cabal-wrapped" | ||
| ''; | ||
| }) cabal-install; |
Contributor
Author
There was a problem hiding this comment.
Is there a cleaner way to do this?
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes
cabal-installto remove references to GHC, mostly through other libraries that are included in the binary.Should also fix
tests.haskell.shellFor.See: #304352
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.