temurin-bin: init at 22, update sources#314377
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Infinidoge
force-pushed
the
bump-openjdk-temurin
branch
2 times, most recently
from
74cbc0e to
2b997ef
Compare
In Python, a parenthesized expression is a tuple iff there is a comma between the parentheses. In order to have a 1-tuple, we need one more comma.
Infinidoge
force-pushed
the
bump-openjdk-temurin
branch
from
2b997ef to
7717ee9
Compare
|
Retargeted to staging due to the rebuild count |
| ../development/compilers/zulu/22.nix | ||
| { | ||
| openjdk22-bootstrap = temurin-bin.jdk-21; | ||
| openjdk22-bootstrap = temurin-bin.jdk-22; |
There was a problem hiding this comment.
Not a big deal, but I think we should keep the version at 21 here, to align with the recommended version in the OpenJDK build documentation:
... the boot JDK for building JDK major version N should be a JDK of major version N-1
There was a problem hiding this comment.
All recent versions of Java build with major version N, so this keeps it consistent.
There was a problem hiding this comment.
Do we know why? Seems to make more sense to bootstrap with N-1 tbh...
There was a problem hiding this comment.
If the concern is to keep it consistent, then we should use N-1 everywhere. Using the same version introduces a cyclic dependency. Also, it makes sense to follow the recommendation from OpenJDK build docs.
There was a problem hiding this comment.
I'm not sure how it introduces a cyclic dependency, because the binary package has no dependency on Java.
IMO LTS releases should definitely be built with the N version, because otherwise it introduces a dependency on a package that will be marked insecure. Non-LTS, either way works.
I don't really see the recommendation as an extremely compelling reason, because they note in the same paragraph that N is also acceptable, but that's just me.
There was a problem hiding this comment.
I hadn't considered the dependency on an EOL JDK. That's a good point.
By cyclic dependency, I mean that Temurin depends on the same OpenJDK source code that the derivation does.
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
bit weird with the bootstrap, but LGTM nonetheless
| ../development/compilers/zulu/22.nix | ||
| { | ||
| openjdk22-bootstrap = temurin-bin.jdk-21; | ||
| openjdk22-bootstrap = temurin-bin.jdk-22; |
There was a problem hiding this comment.
Do we know why? Seems to make more sense to bootstrap with N-1 tbh...
wegank
added
the
12.approvals: 2
5 participants
Description of changes
Split from #286267
CCing @thiagokokada @philiptaron as previous reviewers
Adds temurin bin 22, and regenerates the sources file
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.