Skip to content

Comments

Fix haskellPackages.{chs-cabal,libarchive,archive-libarchive}#313661

Merged
ncfavier merged 2 commits intoNixOS:haskell-updatesfrom
blitz:chs-cabal-fix
May 23, 2024
Merged

Fix haskellPackages.{chs-cabal,libarchive,archive-libarchive}#313661
ncfavier merged 2 commits intoNixOS:haskell-updatesfrom
blitz:chs-cabal-fix

Conversation

@blitz
Copy link
Contributor

@blitz blitz commented May 22, 2024

Description of changes

chs-cabal 0.1.1.2 requires Cabal 3.12, which we do not use yet to maintain GHC compatibility. It also has no features beyond upgrading its Cabal dependency. Downgrade to unbreak it and some transitive dependencies.

This is my first PR in haskellPackages. I ran ./maintainers/scripts/haskell/regenerate-hackage-packages.sh --do-commit to update the autogenerated files.

Discussed with @maralorn in the Haskell matrix channel.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 22, 2024
@blitz
Copy link
Contributor Author

blitz commented May 22, 2024

Result of nixpkgs-review pr 313661 run on x86_64-linux 1

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 22, 2024
@blitz blitz marked this pull request as ready for review May 22, 2024 13:36
@ncfavier
Copy link
Member

Please target haskell-updates

@blitz blitz changed the base branch from master to haskell-updates May 22, 2024 21:06
blitz added 2 commits May 23, 2024 11:47
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
@blitz
Copy link
Contributor Author

blitz commented May 23, 2024

Please target haskell-updates

@ncfavier Done!

@ncfavier ncfavier merged commit 9019791 into NixOS:haskell-updates May 23, 2024
@blitz blitz deleted the chs-cabal-fix branch May 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants