Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.distorm3: disable on Python 3.12 #313655

Merged
merged 3 commits into from
May 22, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 22, 2024

Description of changes

Still uses distutils, gdabah/distorm#191

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 22, 2024
@fabaff
Copy link
Member Author

fabaff commented May 22, 2024

Result of nixpkgs-review pr 313655 run on x86_64-linux 1

2 packages built:
  • python311Packages.distorm3
  • python311Packages.distorm3.dist

@wegank wegank merged commit 5b0e7d5 into NixOS:master May 22, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants