Skip to content

Comments

haskellPackages.sv2v: remove broken flag#313171

Merged
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
newAM:sv2v-fix
May 20, 2024
Merged

haskellPackages.sv2v: remove broken flag#313171
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
newAM:sv2v-fix

Conversation

@newAM
Copy link
Member

@newAM newAM commented May 20, 2024

Description of changes

This package is no longer broken as of #311940 when it got updated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 20, 2024
@ncfavier
Copy link
Member

That file is auto-generated; please edit pkgs/development/haskell-modules/configuration-hackage2nix/broken.yaml instead.

@newAM
Copy link
Member Author

newAM commented May 20, 2024

That file is auto-generated; please edit pkgs/development/haskell-modules/configuration-hackage2nix/broken.yaml instead.

Done. Do I also update the auto-generated file or will that happen automatically?

@ncfavier
Copy link
Member

You can run maintainers/scripts/haskell/regenerate-hackage-packages.sh, but that will happen eventually before we merge haskell-updates. Also, please target haskell-updates.

@newAM newAM changed the base branch from master to haskell-updates May 20, 2024 16:27
@newAM
Copy link
Member Author

newAM commented May 20, 2024

Done! Thanks for the guidance, I appreciate it!

@ncfavier ncfavier merged commit f9261b6 into NixOS:haskell-updates May 20, 2024
@newAM newAM deleted the sv2v-fix branch May 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants