Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pythonfinder: fix build #313119

Merged
merged 1 commit into from
May 20, 2024

Conversation

patka-123
Copy link
Contributor

@patka-123 patka-123 commented May 20, 2024

Description of changes

The build was broken as can be seen here. The Pydantic patch no longer worked because the project no longer uses pydantic.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 313119 run on x86_64-linux 1

4 packages built:
  • python311Packages.pythonfinder
  • python311Packages.pythonfinder.dist
  • python312Packages.pythonfinder
  • python312Packages.pythonfinder.dist

@mweinelt mweinelt merged commit edb6aaf into NixOS:master May 20, 2024
9 of 12 checks passed
@ofborg ofborg bot requested a review from cpcloud May 20, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants