llvmPackages: 17.0.6 -> 18.1.5 on Linux#312981
Conversation
RossComputerGuy
left a comment
There was a problem hiding this comment.
I see we use else 17, is there a reason why we don't change it to 18 or are we only sticking to updating Linux to 18?
|
Tried a |
That's a very surprisingly high number, especially considering most of my test builds were on aarch64-linux. I often find nixpkgs-review struggles to handle and isn't very useful for builds that big, because it eats memory, causes huge CPU contention leading to test timeouts, etc. Can you test a sample of the packages it reported broken and see if they actually are? |
One of them was every package in the |
|
I tried on the aarch64 builder and it appears that works better. Must be Apple Silicon related weirdness. |
|
Builds fine for me on Apple Silicon, fwiw. |
|
Strange, I know I'm on an older version of things (23.11 with 6.6.0-asahi) but it at least has better results on the aarch64 builder box. |
|
If you only tried building with nixpkgs-review, it was very probably the CPU or memory contention issues I mentioned before. |
Description of changes
The next staging cycle will likely have Rust using LLVM 18 (#309580), so to avoid ending up with more LLVMs in closures than necessary, it's time to start working on upgrading the default in general.
I've built all my systems with LLVM 18 with no build regressions (which is better than 16 -> 17, where there was 1), so hopefully it'll just be a few leaf packages that need to have their LLVM versions pinned. Or maybe we'll be lucky, and the pinning from last round will mean there aren't any?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.