[Backport release-23.11] Add types.attrTag#312693
Merged
roberth merged 17 commits intoNixOS:release-23.11from May 23, 2024
Merged
[Backport release-23.11] Add types.attrTag#312693roberth merged 17 commits intoNixOS:release-23.11from
types.attrTag#312693roberth merged 17 commits intoNixOS:release-23.11from
Conversation
This comment was added in 73f32d0, when it was already supposed to be an attrset.
lib.types.attrTag needs it.
You can find them in the sub-options now.
Thank you lheckemann for pointing this out!
Keep it simple for now.
I haven't managed to trigger the error, and it turns out that this method is optional. Specifically, getSubmodules is unimplemented (and unimplementable), the tests pass, and we seem to have good location info.
Committing because tests pass. Co-authored-by: Silvan Mosberger <github@infinisil.com>
github-actions
bot
added
6.topic: nixos
This fixes up the backport to 23.11; the documentation rework commits were dropped for simplicity, so only the simple initial doc remained, and had to be updated to reflect the later syntax: options, not types.
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport of #284551 minus docs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.