Closed
Conversation
eclairevoyant
previously requested changes
May 17, 2024
It requires gobject-introspection, don't ask me why a CLI has any need for that.
ofborg
bot
added
10.rebuild-darwin: 0
jtojnar
requested changes
May 18, 2024
Member
jtojnar
left a comment
jtojnar
left a comment
There was a problem hiding this comment.
This is fallout from gobject-introspection moving glib typelibs to glib package, see #306080 (comment)
| buildInputs = [ | ||
| glib systemd udev libevdev json-glib libunistring | ||
| (python3.withPackages (ps: with ps; [ evdev pygobject3 ])) | ||
| gobject-introspection # ratbagctl needs this |
Member
There was a problem hiding this comment.
It needs it for setup hook, so it should go to nativeBuildInputs.
|
|
||
| nativeBuildInputs = [ | ||
| meson ninja pkg-config gitMinimal swig check valgrind | ||
| meson ninja pkg-config gitMinimal swig check valgrind wrapGAppsHook3 |
Member
There was a problem hiding this comment.
For the wrapper to find glib typelibs, wrapGAppsNoGuiHook should be sufficient
Contributor
|
fixed in #316717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It requires gobject-introspection, don't ask me why a CLI has any need for that.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.