moneydance: restrict supported platforms to linux#312409
Merged
wegank merged 1 commit intoNixOS:masterfrom May 17, 2024
Merged
Conversation
ghost
approved these changes
May 17, 2024
ghost
left a comment
There was a problem hiding this comment.
LGTM.
tested
NIXPKGS_ALLOW_UNFREE=1 nix-instantiate -A moneydance --show-trace --argstr system aarch64-darwin
does not abort and crash eval.
Comment on lines
+56
to
+57
| # Darwin refers to Zulu Java, which breaks the evaluation of this derivation | ||
| # for some reason |
There was a problem hiding this comment.
zulu java doesn't seem have an argument named openjfx, which seems to be causing the error.
error: function 'anonymous lambda' called with unexpected argument 'openjfx'
at /Users/anna/src/nix.1/pkgs/development/compilers/zulu/common.nix:1:1:
Member
Author
|
I would want to get this in before 24.05 - the breakage is inconsistent for me (I can run nixpkgs-review for some packages, but some fail to evaluate), and I'm not sure what the broader consequences of this are cc @NixOS/nixos-release-managers |
Contributor
|
Thank you @RaghavSood! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This removes Darwin from the supported platforms for
moneydance.#306372 unintentionally breaks the package set evaluation (in some cases, I'm not quite sure what triggers it) for aarch64-darwin (see logs)
Before
raghavsood@r-mbp-a15> nix-build -A moneydance ~/r/local/dev/github.com/RaghavSood/nixpkgs error: … in the condition of the assert statement
After
raghavsood@r-mbp-a15> NIXPKGS_ALLOW_UNFREE=1 nix-build -A moneydance ~/r/local/dev/github.com/RaghavSood/nixpkgs error: … in the condition of the assert statement
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.