Skip to content

util-linux: try to fix parallel build failures#311988

Closed
alyssais wants to merge 1 commit intoNixOS:stagingfrom
alyssais:util-linux-parallel
Closed

util-linux: try to fix parallel build failures#311988
alyssais wants to merge 1 commit intoNixOS:stagingfrom
alyssais:util-linux-parallel

Conversation

@alyssais
Copy link
Member

Description of changes

Difficult to know if these actually fix it, since it only happens sometimes.

See #309805 (comment).

Should be backported to 24.05 once possible.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Difficult to know if these actually fix it, since it only happens
sometimes.

Link: NixOS#309805 (comment)
Link: https://lore.kernel.org/util-linux/87le4c1zm4.fsf@alyssa.is/
@alyssais alyssais requested a review from vcunat May 15, 2024 16:17
@vcunat
Copy link
Member

vcunat commented May 15, 2024

I was now trying to reproduce the failure on the community 80-core aarch64 (without these patches), but I failed, even though the machine was almost idle. So I don't know.

@alyssais
Copy link
Member Author

I've seen it locally before too. I didn't realise it was transient at the time, because it went away after I did some other work on the package.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 15, 2024
vcunat added a commit that referenced this pull request May 17, 2024
Difficult to know if these actually fix it, since it only happens
sometimes.

Link: #309805 (comment)
Link: https://lore.kernel.org/util-linux/87le4c1zm4.fsf@alyssa.is/

vcunat edit: only apply on some platforms for now,
balancing fixes and the amount of rebuild work on Hydra.
The rest is picked from PR #311988
@vcunat vcunat self-assigned this May 17, 2024
@vcunat
Copy link
Member

vcunat commented May 18, 2024

If I didn't mess up something, this (i686) build used the patches and failed apparently in the same way again:
https://hydra.nixos.org/build/260133082

@alyssais
Copy link
Member Author

If I didn't mess up something, this (i686) build used the patches and failed apparently in the same way again:
https://hydra.nixos.org/build/260133082

Reported

@alyssais alyssais added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 18, 2024
alyssais added a commit to alyssais/nixpkgs that referenced this pull request May 22, 2024
This reverts commit 57bdbab.

Too many issues with 2.40 for now — we're reverting to 2.39.

Fixes: NixOS#311988
@sternenseemann
Copy link
Member

I think this was an instance of this problem? Restarted the build.

@alyssais
Copy link
Member Author

Looks like it.

@vcunat vcunat removed their assignment May 24, 2024
github-actions bot pushed a commit that referenced this pull request May 24, 2024
This reverts commit 57bdbab.

Too many issues with 2.40 for now — we're reverting to 2.39.

Fixes: #311988
(cherry picked from commit 0dbb16a)
@sternenseemann
Copy link
Member

Unfortunately, restarting doesn't seem to help at all with that particular build…

@alyssais
Copy link
Member Author

The util-linux upgrade has been reverted in staging, if that's helpful.

@alyssais alyssais closed this Jun 4, 2024
@alyssais alyssais deleted the util-linux-parallel branch June 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants