python311Packages.tensorflow-bin: 2.15.0 -> 2.16.1#311945
Merged
samuela merged 2 commits intoNixOS:masterfrom May 19, 2024
Merged
python311Packages.tensorflow-bin: 2.15.0 -> 2.16.1#311945samuela merged 2 commits intoNixOS:masterfrom
samuela merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 11-100
samuela
approved these changes
May 15, 2024
Member
samuela
left a comment
samuela
left a comment
There was a problem hiding this comment.
diff LGTM happy to merge assuming everything builds fine
wegank
added
the
12.approvals: 1
GaetanLepage
force-pushed
the
tensorflow-bin
branch
from
56e292c to
e317e98
Compare
Contributor
Author
|
Result of 14 packages marked as broken and skipped:
18 packages built:
|
Contributor
Author
|
Result of 14 packages marked as broken and skipped:
18 packages built:
|
GaetanLepage
force-pushed
the
tensorflow-bin
branch
from
e317e98 to
9a6fd43
Compare
GaetanLepage
commented
May 17, 2024
| -e "s/Requires-Dist: numpy (.*)/Requires-Dist: numpy/" | ||
| ) | ||
| wheel pack ./unpacked/tensorflow* | ||
| mv *.whl $orig_name # avoid changes to the _os_arch.whl suffix |
Contributor
Author
There was a problem hiding this comment.
This was making the darwin build fail:
Unpacking to: unpacked/tensorflow-2.16.1...OK
Repacking wheel as ./tensorflow-2.16.1-cp311-cp311-macosx_12_0_arm64.whl...OK
mv: 'tensorflow-2.16.1-cp311-cp311-macosx_12_0_arm64.whl' and './tensorflow-2.16.1-cp311-cp311-macosx_12_0_arm64.whl' are the same file
Apparently, removing it does not make the linux builds fail, so I completely deleted it.
Contributor
There was a problem hiding this comment.
Apparently this was introduced specifically for darwin: 6a2dad3
Contributor
There was a problem hiding this comment.
Is it the intention for tensorflow-bin to support multiple versions of tensorflow in a single nixpkgs revision (e.g. through overrides)? I see the attrset entries contain a "version" field. This change might be breaking non-default instantiations of tensorflow-bin, maybe we should test them and if they fail - make the mv conditional rather than remove it. I say "maybe" because I don't know if this feature actually has any users
Contributor
Author
There was a problem hiding this comment.
Well, as it was introduced as a "fix" for darwin (which it probably was at the time), I assume than we can remove it now... as it is the cause of this new failure.
What is your take on this @veprbl ?
Contributor
Author
|
Ok, this is good for me ! Summary:
-> @samuela (or anyone) you may merge if no other objection is raised :) |
wegank
removed
the
12.approvals: 1
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
16 packages built:
|
| "$out/${python.sitePackages}/tensorflow/python/saved_model" | ||
| "$out/${python.sitePackages}/tensorflow/python/util" | ||
| "$out/${python.sitePackages}/tensorflow/tsl/python/lib/core" | ||
| "$out/${python.sitePackages}/tensorflow.libs/" |
Contributor
There was a problem hiding this comment.
A note for later: I think it's best that we get rid of the custom fixup logic. There are many other places in nixpkgs where implement a similar logic, which was the motivation for the now-abandoned #297590
Member
|
Proceeding with merge. We can handle #311945 (comment) in a future PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/tensorflow/tensorflow/releases/tag/v2.16.1
cc @jyp @abbradar
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.