graylog-5_2: 5.2.4 -> 5.2.7#310349
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom May 13, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Result of 1 package built:
|
getchoo
approved these changes
May 11, 2024
getchoo
added
the
12.approvals: 1
drupol
previously requested changes
May 12, 2024
| version = "5.2.4"; | ||
| sha256 = "sha256-TbZMRMLpYlg6wrsC+tDEk8sLYJ1nwJum/rL30CEGQcw="; | ||
| version = "5.2.7"; | ||
| sha256 = "sha256-so9IHX0r3dmj5wLrLtQgrcXk+hu6E8/1d7wJu1XDcVA="; |
Contributor
There was a problem hiding this comment.
Prefer hash = ... to sha256 = ... Both currently work, but the former will make it easier if the algorithm ever needs to change.
Since there could be different hashing algorithms in use, this make sense.
More info: https://nixos.org/manual/nixpkgs/stable/#fetchurl
Nixpkgs contributors are currently recommended to use hash.
SuperSandro2000
dismissed
drupol’s stale review
not that important to block the merge of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.