Skip to content

Comments

strip: --strip-all in libexec, bin, sbin#31025

Closed
lukateras wants to merge 1 commit intoNixOS:stagingfrom
lukateras:strip
Closed

strip: --strip-all in libexec, bin, sbin#31025
lukateras wants to merge 1 commit intoNixOS:stagingfrom
lukateras:strip

Conversation

@lukateras
Copy link
Member

Motivation for this change

#21667 (comment)
#21667 (comment)

I haven't rebuilt system with this patch yet, but @peterhoeg has.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 31, 2017
@vcunat vcunat changed the base branch from master to staging November 6, 2017 12:20
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Nov 8, 2017
@globin
Copy link
Member

globin commented Nov 9, 2017

@nixborg build

@nixborg
Copy link

nixborg commented Nov 9, 2017

Jobset created at https://hydra.mayflower.de/jobset/nixos/pr-31025

@globin
Copy link
Member

globin commented Nov 13, 2017

@lukateras
Copy link
Member Author

It's very strange for it to fail like that. How does this end up pulling dev paths?

@peterhoeg
Copy link
Member

Any plans to fix the merge conflict so we can get this merged?

@lukateras
Copy link
Member Author

Sure, I can resolve the conflict. Although, are you sure that would make it mergeable? Jobs placed by @globin failed with output is not allowed to refer to path.

@peterhoeg
Copy link
Member

I really want to get the bottom of this so we can get it merged.

@lukateras
Copy link
Member Author

Rebased!

@peterhoeg
Copy link
Member

@globin, any chance nixborg can try this again?

@infinisil
Copy link
Member

@GrahamcOfBorg eval

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Are there any updates on this pull request, please?

@mmahut
Copy link
Member

mmahut commented Jan 24, 2020

Closing due to inactivity.

@mmahut mmahut closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants