strip: --strip-all in libexec, bin, sbin#31025
Closed
lukateras wants to merge 1 commit intoNixOS:stagingfrom
Closed
strip: --strip-all in libexec, bin, sbin#31025lukateras wants to merge 1 commit intoNixOS:stagingfrom
lukateras wants to merge 1 commit intoNixOS:stagingfrom
Conversation
8 tasks
Member
|
@nixborg build |
|
Jobset created at https://hydra.mayflower.de/jobset/nixos/pr-31025 |
Member
Author
|
It's very strange for it to fail like that. How does this end up pulling |
Member
|
Any plans to fix the merge conflict so we can get this merged? |
Member
Author
|
Sure, I can resolve the conflict. Although, are you sure that would make it mergeable? Jobs placed by @globin failed with |
Member
|
I really want to get the bottom of this so we can get it merged. |
Member
Author
|
Rebased! |
Member
|
@globin, any chance nixborg can try this again? |
Member
|
@GrahamcOfBorg eval |
Member
|
Are there any updates on this pull request, please? |
Member
|
Closing due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#21667 (comment)
#21667 (comment)
I haven't rebuilt system with this patch yet, but @peterhoeg has.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)