Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edgedb: 4.1.1 -> 5.1.0 #309768

Merged
merged 2 commits into from
May 22, 2024
Merged

edgedb: 4.1.1 -> 5.1.0 #309768

merged 2 commits into from
May 22, 2024

Conversation

0x50F1A
Copy link
Contributor

@0x50F1A 0x50F1A commented May 7, 2024

Description of changes

  • Update source from 4.1.1 to 5.1.0
  • Re-vendor Cargo.lock
  • Fix ELF patch
  • Format with nixfmt

Diff: edgedb/edgedb-cli@v4.1.1...v5.1.0

Changelog: https://docs.edgedb.com/changelog/5_x

Things done

nix shell .#edgedb
edgedb -V
edgedb project init
# ...
edgedb
select "foo";
# {'foo'}
\quit
edgedb instance destroy -I nixpkgs --force
edgedb branch
rm -rf dbschema
rm edgedb.toml
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@kirillrdy
Copy link
Member

while release notes don't include words such as "breaking changes"

there is

The CLI will first check to see if your schema will migrate cleanly to EdgeDB 5.0. If the upgrade check finds any problems, it will report them back to you.

currently all branches are in

Restrict all breaking changes with the exception of desktop environments

I would recommend to wait until 24.05 is released

@ahirner
Copy link
Contributor

ahirner commented May 7, 2024

Format with nixfmt

Thx!
Builds and works for x86_64-darwin.

currently all branches are in

I observed that 5.1.0 does provide hints in a sane way, e.g. before changing dbschema/migration formats:

image

Anyway, I support to not backport and add a release note for 24.05.

This would still go to unstable, or is there another staging mechanism @kirillrdy ? Pardon if that should be obvious from Contributing.md.

@kirillrdy
Copy link
Member

as per #303285

2024-05-01 all branches Restrict all breaking changes with the exception of desktop environments

you can set PR to draft and wait until Branch-off then it can be merged into master and will be part of 24.11 release

this all, assuming 5.x is considered "breaking changes" release, that I don't have a strong opinion about

Copy link
Contributor

@ahirner ahirner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes (FWIW) got unrestricted as of 2014-05-15.

@kirillrdy
Copy link
Member

Breaking changes (FWIW) got unrestricted as of 2014-05-15.

Only for staging branch

@ahirner ahirner self-requested a review May 18, 2024 05:06
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels May 18, 2024
@kirillrdy kirillrdy merged commit 9eb52cb into NixOS:master May 22, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants