Skip to content

waybar: 0.10.2 -> 0.10.3#309516

Merged
dywedir merged 2 commits intoNixOS:masterfrom
JohnRTitor:waybar
May 6, 2024
Merged

waybar: 0.10.2 -> 0.10.3#309516
dywedir merged 2 commits intoNixOS:masterfrom
JohnRTitor:waybar

Conversation

@JohnRTitor
Copy link
Member

@JohnRTitor JohnRTitor commented May 6, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@JohnRTitor
Copy link
Member Author

JohnRTitor commented May 6, 2024

Note: this should be merged before #309075 lands, otherwise users gonna have a broken bar.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 6, 2024
@Gliczy
Copy link
Member

Gliczy commented May 6, 2024

Result of nixpkgs-review pr 309516 run on x86_64-linux 1

1 package built:
  • waybar

Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected!

@Gliczy Gliczy added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 6, 2024
@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 309516 run on aarch64-linux 1

1 package built:
  • waybar

@dywedir
Copy link
Member

dywedir commented May 6, 2024

Thanks!

@dywedir dywedir merged commit af26b72 into NixOS:master May 6, 2024
@JohnRTitor JohnRTitor deleted the waybar branch May 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants