Skip to content

boehmgc: disable tests on aarch64-linux#309418

Merged
Aleksanaa merged 1 commit intoNixOS:stagingfrom
ckiee:boehm-qemu-user-aarch64
May 24, 2024
Merged

boehmgc: disable tests on aarch64-linux#309418
Aleksanaa merged 1 commit intoNixOS:stagingfrom
ckiee:boehm-qemu-user-aarch64

Conversation

@ckiee
Copy link
Member

@ckiee ckiee commented May 6, 2024

double whammy!

Description of changes

on an x86_64-linux machine with the qemu-user for aarch64-linux:
nix-build -E 'with import (builtins.getFlake "github:nixos/nixpkgs/25865a40d14b3f9cf19f19b924e2ab4069b09588") {}; boehmgc.overrideAttrs(o: {version = o.version + "-meow";})' --system aarch64-linux (nixos-unstable)
fails.

not building everything, hence staging target.

assuming previous doCheck condition is about a recent aarch64-darwin host running Rosetta emu for x86_64-darwin.

don't be 100% i'm right, i'm very sleepy.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ckiee ckiee force-pushed the boehm-qemu-user-aarch64 branch from 179afb3 to 44a2d11 Compare May 6, 2024 01:10
@ckiee ckiee force-pushed the boehm-qemu-user-aarch64 branch from 44a2d11 to 14c3b26 Compare May 6, 2024 01:20
@ckiee ckiee marked this pull request as ready for review May 6, 2024 01:24
@ofborg ofborg bot requested a review from AndersonTorres May 6, 2024 03:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 6, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 7, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1655

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 19, 2024
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn!

@Aleksanaa Aleksanaa merged commit 1447e05 into NixOS:staging May 24, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions
Copy link
Contributor

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-309418-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-309418-to-staging-24.05
git switch --create backport-309418-to-staging-24.05
git cherry-pick -x 14c3b26610dcc86311393a2c0e3f01df048127fd

@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants