sphinxcontrib-ditaa: init at 1.0.2#309307
Closed
Rconybea wants to merge 3 commits intoNixOS:masterfrom
Closed
Conversation
Sphinx plugin that invokes ditaa to nicely render ascii block diagram art No built-in tests; tested manually on x86_64.
github-actions
bot
added
6.topic: python
NixOSInfra
added
the
12.first-time contribution
ofborg
bot
added
8.has: package (new)
Member
|
Your commits are breaking Commit Conventions please rebase. In your case reword 0ad2611 to Please also change your PR title to: |
FlameFlag
reviewed
May 5, 2024
Contributor
Author
|
Created new PR reflecting review feedback here: #309426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add sphinx plugin to invoke ditaa.
Executable content comprises about 200 lines of python.
nix package adapted from sphinxcontrib-blockdiag
Things done
Using successfully for sphinx-generated documentation in xo-unit (https://github.com/rconybea/xo-unit),
and user environment in xo-nix2 (https://github.com/rconybea/xo-nix2/flake.nix)
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.