thunderbirdPackages.thunderbird-102: convert to a throw#308820
Merged
alyssais merged 2 commits intoNixOS:masterfrom May 12, 2024
Merged
thunderbirdPackages.thunderbird-102: convert to a throw#308820alyssais merged 2 commits intoNixOS:masterfrom
throw#308820alyssais merged 2 commits intoNixOS:masterfrom
Conversation
Member
Author
|
As pointed out, maybe someone could consider it a breaking change, even if the package was marked as insecure. In that case we'd need to wait with the merge after 24.05 fork-off. |
vcunat
changed the title
throw
ofborg
bot
added
10.rebuild-darwin: 0
drupol
approved these changes
May 4, 2024
27 tasks
alyssais
reviewed
May 10, 2024
|
|
||
| pgoSupport = false; # console.warn: feeds: "downloadFeed: network connection unavailable" | ||
| }; | ||
| thunderbird-102 = throw "Thunderbird 102 support ended in September 2023"; |
Member
There was a problem hiding this comment.
Throws like this should be gated on config.allowAliases.
Member
There was a problem hiding this comment.
- It's just what the convention in Nixpkgs is. top-level throws go in aliases.nix, which isn't included if allowAliases is set to false, and it's nice to not have that be surprisingly different for non-top-level ones.
- It makes it so that there's a way to bulid a whole package set at once, even if it contains throws —
nix-build -A thunderbirdPackages --arg config '{allowAliases = false;}'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Add a 👍 reaction to pull requests you find important.