nextcloud-client-bin: init at 3.13.0

[ArkieSoft]

Description of changes

Adds separate package since it is not built from source like nextcloud-client. Allows room in the future to add linux capability.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[FlameFlag]

Please move your package to pkgs/by-name/ne/nextcloud-client-bin.

Also, please follow Commit Conventions. In your case, rebase, squash your commits, and reword the final commit to be nextcloud-client-bin: init at 3.13.0

EDIT: Create a package.nix and move over all 3 files into it. If possible, please also use your GitHub email and username for the commits.

[FlameFlag]

No need to leave comments about changes in the init commit. Also, please move all the 3 files into a single package.nix file

[FlameFlag]

It would also be nice if you could use your GitHub name and email for this PR. If you're worried about the privacy of your email, you can use the users.noreply.github.com email provided by GitHub. You can see it here https://github.com/settings/emails

[FlameFlag]

Suggested change

	}
	)
	})

Just a small nit

[FlameFlag]

I would recommend you to do a "soft reset" by using git reset --soft HEAD~1 to remove your old name and email from the commit. It will delete the commit from the history and move it's changes back into the staging area. However, make sure to commit your changes first before doing this.

[FlameFlag]

I would recommend you run nixpkgs-fmt on your package.nix next time to automatically comply with formatting code conventions

[ArkieSoft]

Installed nixpkgs-fmt and reformatted package.nix. Hopefully that works as intended

[FlameFlag]

Result of nixpkgs-review pr 308426 run on aarch64-darwin 1

1 package built:

• nextcloud-client-bin

[ArkieSoft]

I didn't want to be so forward on that. I am more than willing to be a maintainer for this. I pushed a commit adding me as a maintainer.

[FlameFlag]

You will need to add yourself to the maintainer list in that case. Please take a look at https://github.com/NixOS/nixpkgs/tree/master/maintainers

[FlameFlag]

Adding yourself to the maintainer list should be a separate commit and should be worded as such maintainers: add ArkieSoft

[ArkieSoft]

Awaiting being added to maintainers

[FlameFlag]

Please rebase, delete 3537384 and move 4239339 to be before 78d7178

[SuperSandro2000]

Did you try building the source package on darwin? What made you decide that it is not feasible?

[SuperSandro2000]

Closing because of no answer from author.