Conversation
ofborg
bot
added
8.has: package (new)
afh
left a comment
afh
left a comment
There was a problem hiding this comment.
Thank your for accepting the suggestions and making the appropriate changes, much appreciated, @quag.
Please find below two more suggestions. I feel "strongly" about the superfluous use of pname as there is a tree-wide change being drafted (see #278611) and much less strongly about meta.description. Hence I kindly request changes for the former and leave accepting or dismissing the latter at your discretion 🙂
|
Result of 1 package built:
|
pkgs/by-name/ge/gema/package.nix
Outdated
There was a problem hiding this comment.
My sincerest apologies for failing to communicate this better, @quag, meta attributes are not "strictly" sorted alphabetically as it does make much sense for description and longDescription to be next to each other.
| description = "General purpose text processing utility based on the concept of pattern matching."; | |
| homepage = "https://gema.sourceforge.net/"; | |
| license = lib.licenses.mit; | |
| longDescription = "Reads an input file and copies it to an output file transforming the data as specified by the patterns defined by the user."; | |
| description = "General purpose text processing utility based on the concept of pattern matching."; | |
| longDescription = "Reads an input file and copies it to an output file transforming the data as specified by the patterns defined by the user."; | |
| homepage = "https://gema.sourceforge.net/"; | |
| license = lib.licenses.mit; | |
There was a problem hiding this comment.
Haha. Fixed! Thanks for all your help. Every time I submit a package I learn a lot from people like yourself. I appreciate it.
There was a problem hiding this comment.
I'm merely passing on what I have learned from others who generously shared their knowledge and expertise.
It would make day and be helpful for project if you feel like doing the same for others 🙂
There was a problem hiding this comment.
I would like to help. Is there a good way or place to start?
There was a problem hiding this comment.
That's great to hear, @quag 😃
An excellent start is CONTRIBUTING.md. The nixpkgs repo also provides many README.md files, the ones I found interesting and insightful are pkgs/README.md and pkgs/by-name/README.md. These READMEs contain links to other READMEs, so I think this should be plenty to dig into for a start. Feel to share interesting tidbits with me that you find, I'm always curious to hear what others come across.
I've made it an occasional habit to look for new package pull requests that seem a good fit for me to review—this is how I came across this PR 🙂
Is this helpful for you and answers your question, @quag?
afh
left a comment
afh
left a comment
There was a problem hiding this comment.
Excellent, thank you for your patience and putting in all the work to get this polished up, @quag, very much appreciated! 🙏
This is looking splendid from my end. Let's get this merged by someone with a commit bit—unless, of course, other nix-savvy folks have objections…
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1612 |
4 participants
Description of changes
gema is a general purpose text processing utility based on the concept of pattern matching. It reads an input file and copies it to an output file transforming the data as specified by the patterns defined by the user.
First made in 1995, v2.0 was released on 2024-03-31.
https://gema.sourceforge.net/new/index.shtml
https://sourceforge.net/projects/gema/
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.