Skip to content

tree-wide: Replace unsupported dontCheck with doCheck attribute #307838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuperSandro2000 merged 3 commits into from
Jun 2, 2024
Merged

tree-wide: Replace unsupported dontCheck with doCheck attribute #307838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a4e74
pyxel: Replace unsupported dontCheck with doCheck attribute
afh May 18, 2024
b4fbf5f
gpt-2-simple: refactor
afh May 18, 2024
a3deb72
kaitaistruct: refactor
afh May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/by-name/py/pyxel/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ python3.pkgs.buildPythonApplication rec {
env.NIX_CFLAGS_COMPILE = "-I${lib.getDev SDL2}/include/SDL2";

# Tests can't use the display
dontCheck = true;
doCheck = false;

pythonImportsCheck = [
"pyxel"
Expand Down
7 changes: 5 additions & 2 deletions pkgs/development/python-modules/gpt-2-simple/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
fetchFromGitHub,
regex,
requests,
setuptools,
tqdm,
numpy,
toposort,
Expand All @@ -13,7 +14,7 @@
buildPythonPackage rec {
pname = "gpt-2-simple";
version = "0.8.1";
format = "setuptools";
pyproject = true;

src = fetchFromGitHub {
owner = "minimaxir";
Expand All @@ -22,6 +23,8 @@ buildPythonPackage rec {
hash = "sha256-WwD4sDcc28zXEOISJsq8e+rgaNrrgIy79Wa4J3E7Ovc=";
};

build-system = [ setuptools ];

propagatedBuildInputs = [
regex
requests
Expand All @@ -31,7 +34,7 @@ buildPythonPackage rec {
tensorflow
];

dontCheck = true; # no tests in upstream
doCheck = false; # no tests in upstream

meta = with lib; {
description = "Easily retrain OpenAI's GPT-2 text-generating model on new texts";
Expand Down
8 changes: 5 additions & 3 deletions pkgs/development/python-modules/kaitaistruct/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
fetchFromGitHub,
brotli,
lz4,
setuptools,
}:

let
Expand All @@ -18,7 +19,7 @@ in
buildPythonPackage rec {
pname = "kaitaistruct";
version = "0.10";
format = "setuptools";
pyproject = true;

src = fetchPypi {
inherit pname version;
Expand All @@ -30,13 +31,14 @@ buildPythonPackage rec {
sed '32ipackages = kaitai/compress' -i setup.cfg
'';

build-system = [ setuptools ];

propagatedBuildInputs = [
brotli
lz4
];

# no tests
dontCheck = true;
doCheck = false; # no tests in upstream

pythonImportsCheck = [
"kaitaistruct"
Expand Down