Skip to content

haskell.packages.ghcjs.stm: fix eval#307558

Merged
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
trofi:haskell.packages.ghcjs.stm-fix-eval
May 13, 2024
Merged

haskell.packages.ghcjs.stm: fix eval#307558
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
trofi:haskell.packages.ghcjs.stm-fix-eval

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 28, 2024

Without the change eval fails as:

$ nix build --no-link -f. haskell.packages.ghcjs.stm
error:
   … in the left operand of the update (//) operator
     at pkgs/development/haskell-modules/lib/compose.nix:40:7:
       39|     mkDerivation = drv: (args.mkDerivation drv).override f;
       40|   })) // {
         |       ^
       41|     overrideScope = scope: overrideCabal f (drv.overrideScope scope);

   error: attribute 'stm_2_5_3_0' missing
   at pkgs/development/haskell-modules/configuration-ghcjs.nix:29:21:
       28|   # https://github.com/ghcjs/ghcjs/issues/676
       29|   stm = doJailbreak self.stm_2_5_3_0;
         |                     ^
       30|   exceptions = dontCheck self.exceptions_0_10_7;
   Did you mean stm_2_5_3_1?

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change eval fails as:

    $ nix build --no-link -f. haskell.packages.ghcjs.stm
    error:
       … in the left operand of the update (//) operator
         at pkgs/development/haskell-modules/lib/compose.nix:40:7:
           39|     mkDerivation = drv: (args.mkDerivation drv).override f;
           40|   })) // {
             |       ^
           41|     overrideScope = scope: overrideCabal f (drv.overrideScope scope);

       error: attribute 'stm_2_5_3_0' missing
       at pkgs/development/haskell-modules/configuration-ghcjs.nix:29:21:
           28|   # ghcjs/ghcjs#676
           29|   stm = doJailbreak self.stm_2_5_3_0;
             |                     ^
           30|   exceptions = dontCheck self.exceptions_0_10_7;
       Did you mean stm_2_5_3_1?
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 28, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 28, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 29, 2024
@ncfavier ncfavier merged commit f7e9730 into NixOS:haskell-updates May 13, 2024
@trofi trofi deleted the haskell.packages.ghcjs.stm-fix-eval branch May 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants