fontbakery: fix passthru.tests for 0.12#307382
Merged
mweinelt merged 4 commits intoNixOS:stagingfrom Apr 28, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
Contributor
Author
|
I wasn't able to run |
This was referenced Apr 28, 2024
ofborg
bot
added
10.rebuild-darwin: 501+
mweinelt
approved these changes
Apr 28, 2024
Member
mweinelt
left a comment
mweinelt
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Python mass-update PR #305152 introduced some build failures in
fontbakeryand its dependencies. This PR fixes them up.This includes an update for
fonttoolssinceufo2ftdepends on a new API added in fonttools 4.50.Things done
For non-Linux: Is sandboxing enabled innix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)[ ] (Package updates) Added a release notes entry if the change is major or breaking[ ] (Module updates) Added a release notes entry if the change is significant[ ] (Module addition) Added a release notes entry if adding a new NixOS moduleAdd a 👍 reaction to pull requests you find important.