Conversation
ghost
mentioned this pull request
13 tasks
Ericson2314
reviewed
Apr 22, 2024
Ericson2314
reviewed
Apr 22, 2024
older LLVMs (12) don't install headers into $dev, so move headers if $out/include exists before the lndir step
Ericson2314
approved these changes
Apr 22, 2024
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
12.approvals: 1
ghost
mentioned this pull request
13 tasks
rrbutani
added
the
12.approved-by: package-maintainer
Repository owner
closed this by deleting the head repository
Apr 23, 2024
rrbutani
added
the
6.topic: llvm/clang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
older LLVMs (12) don't install headers into $dev, so move headers if $out/include exists before the lndir step
cc: @Ericson2314 @RossComputerGuy
#305408
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.