Skip to content

haskellPackages.kmonad: mark as broken on darwin#305823

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
slotThe:kmonad-iokit
Jul 28, 2024
Merged

haskellPackages.kmonad: mark as broken on darwin#305823
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
slotThe:kmonad-iokit

Conversation

@slotThe
Copy link
Member

@slotThe slotThe commented Apr 21, 2024

Description of changes

Related: #304640

I don't have access to MacOS, so I don't know how to actually test this (help? :)), but the error seemed obvious enough.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 21, 2024
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 21, 2024
@sternenseemann
Copy link
Member

Darwin specific overrides should go to configuration-darwin.nix which is unconditionally applied there.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 21, 2024
@sternenseemann sternenseemann marked this pull request as draft April 22, 2024 10:51
@sternenseemann
Copy link
Member

This change does appear to result in a linker failure on darwin.

@slotThe
Copy link
Member Author

slotThe commented Apr 22, 2024

Well that's very confusing… I suppose wrt #304640 we can just mark this package as broken on darwin for the time being.

@slotThe slotThe changed the title haskellPackages.kmonad: Add IOKit dependency for darwin haskellPackages.kmonad: mark as broken on darwin May 3, 2024
@slotThe
Copy link
Member Author

slotThe commented May 3, 2024

@sternenseemann since I don't really have a way to test this, the sanest solution seems to be to just mark the package as broken on darwin for now.

@slotThe slotThe marked this pull request as ready for review May 3, 2024 05:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels May 3, 2024
@maralorn
Copy link
Member

wfm

@maralorn maralorn merged commit bdb82c7 into NixOS:haskell-updates Jul 28, 2024
@sternenseemann
Copy link
Member

Technically, it supports darwin… we just haven't set it up right.

@maralorn
Copy link
Member

Yeah, the old semantic struggle that we can’t trivially mark packages broken based on platform …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants