haskellPackages.kmonad: mark as broken on darwin#305823
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Jul 28, 2024
Merged
haskellPackages.kmonad: mark as broken on darwin#305823maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
Member
|
Darwin specific overrides should go to |
Member
|
This change does appear to result in a linker failure on darwin. |
Member
Author
|
Well that's very confusing… I suppose wrt #304640 we can just mark this package as broken on darwin for the time being. |
Member
Author
|
@sternenseemann since I don't really have a way to test this, the sanest solution seems to be to just mark the package as broken on darwin for now. |
Member
|
wfm |
Member
|
Technically, it supports darwin… we just haven't set it up right. |
Member
|
Yeah, the old semantic struggle that we can’t trivially mark packages broken based on platform … |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Related: #304640
I don't have access to MacOS, so I don't know how to actually test this (help? :)), but the error seemed obvious enough.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)