cargo-modules: 0.11.2 -> 0.15.5#305714
Merged
matthiasbeyer merged 1 commit intoNixOS:masterfrom Apr 21, 2024
Merged
Conversation
Contributor
Author
|
@rvarago @matthiasbeyer @figsoda maintainer ping The old version (0.11.2) was failing tests after the recent rust version bump to 1.77.0 |
matthiasbeyer
approved these changes
Apr 21, 2024
Contributor
|
Please squash the commits into one. The second commit does not follow the commit guidelines. Adding the skips in the update commit is IMO fine, so you can simply squash them. |
Contributor
|
Result of 1 package built:
|
skip failing tests
aktaboot
force-pushed
the
update-cargo-modules
branch
from
2195ca7 to
821fa71
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
matthiasbeyer
approved these changes
Apr 21, 2024
Contributor
|
Result of 1 package built:
|
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Git push to origin failed for release-23.11 with exitcode 1 |
Contributor
|
Backport pushed to #298312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tried debugging why the tests were failing to no avail, help appreciated.
mind that most of the failing tests come from the smoke test framework that hasn't received updates in a while
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.