Update hash for python bootstrap build#304879
Conversation
|
Thanks for noticing. This is too big a rebuild for master, and also for staging-next at this time. It also needs validation, since build sits at the core of python packages, so I'm not sure if we should update, if it wasn't integration tested properly. |
|
Can the version number be reverted so the hash is not wrong? |
|
The src FOD is cached since the hash wasn't invalidated. We require another staging cycle to update it. The currently ongoing #305152 bumps build to 1.2.1. |
|
Looks like this was fixed in #305152. Thanks! |
This was a fairly big deal, is there any plans to protect from it happening again? |
|
NixOS/rfcs#171 would have made this into a build failure |
|
Be the FOD change you want to be |
Description of changes
Updates the hash for the new version of pypa/build. Looks like it was missed in #294305.
Things done
Ran
nix-prefetch-git https://github.com/pypa/build.git refs/tags/1.1.1and replaced the hash with the new hashnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.