cc-wrapper: disable POSIX compatibility#30483
Conversation
Ericson2314
left a comment
There was a problem hiding this comment.
You should make the same change in ld-wrapper.sh, but +1 on concept.
|
@Ericson2314 fixed! EDIT: Fixed also for GNAT. |
|
I don't understand the motivation. Where are we setting |
|
@edolstra A random P.S. I have no idea what Bash developers were thinking when they allowed an environment variable to change how a script is evaluated but oh well. |
|
I'll merge this in several days if noone objects, preferrably after current staging gets in master so that I can proceed with #30433 and related work. |
orivej
left a comment
There was a problem hiding this comment.
This is the third known case of POSIXLY_CORRECT or set -o posix causing trouble, the previous was in #28255 (comment)
|
I wanted to merge this with several additional wrapper patches but I still need to work on them some more. Feel free to batch this together with any mass rebuild change! |
|
There's one gawk update right now, taking with it. |
I'm not sure why this patch was needed, but it builds and works find without it now. Maybe this is connected with #30483
Motivation for this change
When
POSIXLY_CORRECTenvironment variable is set the script runs in sh compatibility mode, which fails because we use process piping in utils.sh. This patch explicitly disables POSIX compatibility mode.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Checked by unsafe editing of script in Nix store and running the compiler on
configurescript which mysteriously failed before.