Skip to content

icu: Make static linking possible #304772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7c6f434c merged 1 commit into from
Apr 23, 2024
Merged

icu: Make static linking possible #304772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkgs/development/libraries/icu/make-icu.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, lib, buildPackages, fetchurl, fixDarwinDylibNames, testers }:

{ version, hash, patches ? [], patchFlags ? [] }:
{ version, hash, patches ? [], patchFlags ? [], withStatic ? stdenv.hostPlatform.isStatic }:

let
# Cross-compiled icu4c requires a build-root of a native compile
Expand Down Expand Up @@ -36,9 +36,12 @@ let
sed -e 's/LDFLAGSICUDT=-nodefaultlibs -nostdlib/LDFLAGSICUDT=/' -i config/mh-linux
'';

dontDisableStatic = withStatic;

configureFlags = [ "--disable-debug" ]
++ lib.optional (stdenv.isFreeBSD || stdenv.isDarwin) "--enable-rpath"
++ lib.optional (stdenv.buildPlatform != stdenv.hostPlatform) "--with-cross-build=${nativeBuildRoot}";
++ lib.optional (stdenv.buildPlatform != stdenv.hostPlatform) "--with-cross-build=${nativeBuildRoot}"
++ lib.optional withStatic "--enable-static";

enableParallelBuilding = true;

Expand All @@ -58,15 +61,18 @@ let
realAttrs = baseAttrs // {
name = pname + "-" + version;

outputs = [ "out" "dev" ];
outputs = [ "out" "dev" ] ++ lib.optional withStatic "static";
outputBin = "dev";

# FIXME: This fixes dylib references in the dylibs themselves, but
# not in the programs in $out/bin.
nativeBuildInputs = lib.optional stdenv.hostPlatform.isDarwin fixDarwinDylibNames;

# remove dependency on bootstrap-tools in early stdenv build
postInstall = lib.optionalString stdenv.isDarwin ''
postInstall = lib.optionalString withStatic ''
mkdir -p $static/lib
mv -v lib/*.a $static/lib
'' + lib.optionalString stdenv.isDarwin ''
sed -i 's/INSTALL_CMD=.*install/INSTALL_CMD=install/' $out/lib/icu/${version}/pkgdata.inc
'' + (let
replacements = [
Expand Down