Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.kserve: init at 0.12.1 #304646

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 16, 2024

Description of changes

Add the python SDK for kserve, a standard Model Inference Platform on Kubernetes, built for highly scalable use cases.

Homepage: https://github.com/kserve/kserve/tree/master/python/kserve

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 304646 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python311Packages.vllm
  • python311Packages.vllm.dist
12 packages built:
  • python311Packages.cloudevents
  • python311Packages.cloudevents.dist
  • python311Packages.kserve
  • python311Packages.kserve.dist
  • python311Packages.ray
  • python311Packages.ray.dist
  • python311Packages.timing-asgi
  • python311Packages.timing-asgi.dist
  • python312Packages.cloudevents
  • python312Packages.cloudevents.dist
  • python312Packages.timing-asgi
  • python312Packages.timing-asgi.dist

@BillHuang2001
Copy link
Contributor

Just want to mention that the update to ray is duplicated to #298297. So if this PR gets merged, I will close the duplicated one.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 304646 run on x86_64-linux 1

10 packages built:
  • python311Packages.cloudevents
  • python311Packages.cloudevents.dist
  • python311Packages.kserve
  • python311Packages.kserve.dist
  • python311Packages.timing-asgi
  • python311Packages.timing-asgi.dist
  • python312Packages.cloudevents
  • python312Packages.cloudevents.dist
  • python312Packages.timing-asgi
  • python312Packages.timing-asgi.dist

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not the python expert so I'll leave this to someone else.

@GaetanLepage GaetanLepage changed the title python311Packages.kserve: init at 0.12.0 python311Packages.kserve: init at 0.12.1 Apr 21, 2024
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 304646 run on x86_64-linux 1

10 packages built:
  • python311Packages.cloudevents
  • python311Packages.cloudevents.dist
  • python311Packages.kserve
  • python311Packages.kserve.dist
  • python311Packages.timing-asgi
  • python311Packages.timing-asgi.dist
  • python312Packages.cloudevents
  • python312Packages.cloudevents.dist
  • python312Packages.timing-asgi
  • python312Packages.timing-asgi.dist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but unfortunately they are not present in the pypi archive:

Executing pytestCheckPhase
total 28
drwxr-xr-x 3 nixbld nixbld 4096 Apr 22 19:09 .
drwx------ 3 nixbld nixbld 4096 Apr 22 19:09 ..
-rw-r--r-- 1 nixbld nixbld 3657 Jan  2  1980 PKG-INFO
-rw-r--r-- 1 nixbld nixbld 2973 Jul 18  2023 README.md
-rw-r--r-- 1 nixbld nixbld  670 Apr 22 19:09 pyproject.toml
-rw-r--r-- 1 nixbld nixbld 3697 Jan  2  1980 setup.py
drwxr-xr-x 3 nixbld nixbld 4096 Apr 22 19:09 timing_asgi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dp we have to care about pypi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used fetchPypi here because there are no releases on Github.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.
Unfortunately, the tests can't run because the required dependency asynctest is "not supported by python 3.11" :')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I switched to fetchFromGithub nonetheless).

pythonImportsCheck = [ "timing_asgi" ];

# Tests rely on asynctest which is not supported by python 3.11
doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be pythonOlder "3.12"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, because ray is not available for Python 3.12.
ray-project/ray#40211

Copy link
Contributor

@SomeoneSerge SomeoneSerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not familiar with Kubernetes. Let's merge not later than tomorrow, unless there are objections

@SomeoneSerge SomeoneSerge merged commit 770458d into NixOS:master Apr 25, 2024
24 checks passed
@GaetanLepage GaetanLepage deleted the kserve branch April 25, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants