-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.kserve: init at 0.12.1 #304646
Conversation
Result of 2 packages marked as broken and skipped:
12 packages built:
|
Just want to mention that the update to |
Result of 10 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not the python expert so I'll leave this to someone else.
Result of 10 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem to have tests? https://github.com/steinnes/timing-asgi/tree/master/tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but unfortunately they are not present in the pypi archive:
Executing pytestCheckPhase
total 28
drwxr-xr-x 3 nixbld nixbld 4096 Apr 22 19:09 .
drwx------ 3 nixbld nixbld 4096 Apr 22 19:09 ..
-rw-r--r-- 1 nixbld nixbld 3657 Jan 2 1980 PKG-INFO
-rw-r--r-- 1 nixbld nixbld 2973 Jul 18 2023 README.md
-rw-r--r-- 1 nixbld nixbld 670 Apr 22 19:09 pyproject.toml
-rw-r--r-- 1 nixbld nixbld 3697 Jan 2 1980 setup.py
drwxr-xr-x 3 nixbld nixbld 4096 Apr 22 19:09 timing_asgi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dp we have to care about pypi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used fetchPypi
here because there are no releases on Github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right.
Unfortunately, the tests can't run because the required dependency asynctest
is "not supported by python 3.11" :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I switched to fetchFromGithub
nonetheless).
pythonImportsCheck = [ "timing_asgi" ]; | ||
|
||
# Tests rely on asynctest which is not supported by python 3.11 | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be pythonOlder "3.12"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no, because ray
is not available for Python 3.12.
ray-project/ray#40211
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'm not familiar with Kubernetes. Let's merge not later than tomorrow, unless there are objections
Description of changes
Add the python SDK for kserve, a standard Model Inference Platform on Kubernetes, built for highly scalable use cases.
Homepage: https://github.com/kserve/kserve/tree/master/python/kserve
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.