elfutils: disable test suite when cross-compiling#304605
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom Apr 30, 2024
Merged
elfutils: disable test suite when cross-compiling#304605sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann merged 1 commit intoNixOS:masterfrom
Conversation
elfutils' test suite uses uname(1) to determine if certain tests can be executed, e.g. it checks for x86_64 to learn whether it can use $CC -m64. Obviously, such checks fall flat if we are compiling from e.g. x86_64 to i686. Instead of skipping known bad tests, just be safe and disable for “executable” cross as well.
ofborg
bot
added
the
6.topic: cross-compilation
ofborg
bot
added
10.rebuild-darwin: 0
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Apr 19, 2024
elfutils is used in the RTS (rts/Libdw.c), i.e. it will be used on the target platform. Tested via pkgsCross.gnu32.haskellPackages.ghc [1], though NixOS#304605 needs to be cherry-picked for elfutils to build. [1]: nix-shell -E 'with import ./. { crossSystem = "i686-linux"; }; mkShell { nativeBuildInputs = [haskellPackages.ghc ]; }'
13 tasks
r-burns
approved these changes
Apr 30, 2024
Contributor
r-burns
left a comment
r-burns
left a comment
There was a problem hiding this comment.
Confirmed, and the change here LGTM.
wegank
added
the
12.approvals: 1
sternenseemann
added a commit
that referenced
this pull request
May 26, 2024
elfutils is used in the RTS (rts/Libdw.c), i.e. it will be used on the target platform. Tested via pkgsCross.gnu32.haskellPackages.ghc [1], though #304605 needs to be cherry-picked for elfutils to build. [1]: nix-shell -E 'with import ./. { crossSystem = "i686-linux"; }; mkShell { nativeBuildInputs = [haskellPackages.ghc ]; }'
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2024
elfutils is used in the RTS (rts/Libdw.c), i.e. it will be used on the target platform. Tested via pkgsCross.gnu32.haskellPackages.ghc [1], though #304605 needs to be cherry-picked for elfutils to build. [1]: nix-shell -E 'with import ./. { crossSystem = "i686-linux"; }; mkShell { nativeBuildInputs = [haskellPackages.ghc ]; }' (cherry picked from commit b868aaa)
sternenseemann
added a commit
that referenced
this pull request
May 26, 2024
elfutils is used in the RTS (rts/Libdw.c), i.e. it will be used on the target platform. Tested via pkgsCross.gnu32.haskellPackages.ghc [1], though #304605 needs to be cherry-picked for elfutils to build. [1]: nix-shell -E 'with import ./. { crossSystem = "i686-linux"; }; mkShell { nativeBuildInputs = [haskellPackages.ghc ]; }' (cherry picked from commit b868aaa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elfutils' test suite uses uname(1) to determine if certain tests can be executed, e.g. it checks for x86_64 to learn whether it can use $CC -m64. Obviously, such checks fall flat if we are compiling from e.g. x86_64 to i686.
Instead of skipping known bad tests, just be safe and disable for “executable” cross as well.
E.g. https://github.com/roolebo/elfutils/blob/master/tests/run-disasm-x86-64.sh.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.