Skip to content

Comments

myxer: init at 1.3.0#304576

Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom
rster2002:publish-myxer
Apr 18, 2024
Merged

myxer: init at 1.3.0#304576
Aleksanaa merged 2 commits intoNixOS:masterfrom
rster2002:publish-myxer

Conversation

@rster2002
Copy link
Contributor

@rster2002 rster2002 commented Apr 16, 2024

Description of changes

Publishes Myxer volume mixer to Nixpkgs. It has been published before, but was removed due do some build issues. Last version that was released was 1.2.1, but as it is not present in the repo I'm publishing it as a new package.

Related issue in application repo: Aurailus/Myxer#30

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 16, 2024
@rster2002 rster2002 changed the title Publish myxer myxer: init at 1.3.0 Apr 16, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 16, 2024
@ofborg ofborg bot requested a review from ErinvanderVeen April 16, 2024 18:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 16, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 16, 2024
Aleksanaa
Aleksanaa reviewed Apr 17, 2024
View reviewed changes
@Aleksanaa
Copy link
Member

Aleksanaa commented Apr 17, 2024

No deprecation alias was found, what were they doing in last removal???

@rster2002 rster2002 force-pushed the publish-myxer branch 2 times, most recently from cee6d8c to 4b6013b Compare April 17, 2024 22:01
@rster2002
Copy link
Contributor Author

rster2002 commented Apr 17, 2024

I've implemented the requested changes. I'm not sure what they did for the last removal or know anything about a deprecation alias. Is this something I should look into?

@rster2002 rster2002 requested a review from Aleksanaa April 17, 2024 22:04
@ofborg ofborg bot requested a review from ErinvanderVeen April 17, 2024 23:02
@Aleksanaa
Copy link
Member

Aleksanaa commented Apr 18, 2024

I've implemented the requested changes. I'm not sure what they did for the last removal or know anything about a deprecation alias. Is this something I should look into?

Nothing. Checked that you don't have to remove a deprecation alias.

Aleksanaa
Aleksanaa reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others looks fine.

@ErinvanderVeen
Copy link
Member

ErinvanderVeen commented Apr 18, 2024

No deprecation alias was found, what were they doing in last removal???

The deprecation warning was absolutely there originally.

https://github.com/NixOS/nixpkgs/pull/176847/files

The deprecation warning must have been removed some time between the removal of the package and this PR.

@rster2002
myxer: init at 1.3.0
efd0311 
Myxer was previously included in Nixpkgs, but was removed after some build issues.
Aleksanaa
Aleksanaa reviewed Apr 18, 2024
View reviewed changes
@Aleksanaa Aleksanaa merged commit 164c9f8 into NixOS:master Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@ErinvanderVeen ErinvanderVeen Awaiting requested review from ErinvanderVeen

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rster2002 @Aleksanaa @ErinvanderVeen @wegank @NixOSInfra