haskell-updates fixes: hevm

[hellwolf]

Description of changes

I am fully aware the ongoing work at argotorg/hevm#471. But in the interest of unblocking hevm and its downstream packages. I made this fix for now, and I will monitor the upstream work and remove the patch when needed.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[maralorn]

Thank you.

Can you follow the examples in configuration-common.nix and fetch this patch from GitHub with fetchpatch?

[hellwolf]

Can you follow the examples in configuration-common.nix and fetch this patch from GitHub with fetchpatch?

Oh, at the moment, there is no such patch as permanent link from github available. I think I found other examples who store patch under pkgs/development/haskell-modules/patches/. What's the guideline here?

[maralorn]

Can you follow the examples in configuration-common.nix and fetch this patch from GitHub with fetchpatch?

Oh, at the moment, there is no such patch as permanent link from github available. I think I found other examples who store patch under pkgs/development/haskell-modules/patches/. What's the guideline here?

I haven’t heard about a patch link which can’t be made into a permanent one. What’s the issue, do you need a commit range? GitHub can do that.

The guideline is: Avoid if sensibly possible.

[hellwolf]

I haven’t heard about a patch link that can’t be made into a permanent one. What’s the issue? Do you need a commit range? GitHub can do that.

I didn't say it was not possible. I was just saying it was not there yet. I will create one in the right place. No problem

The guideline is: Avoid if sensibly possible.

[hellwolf]

Updated the fixes, and now ready for reviewing:

1. hevm patch now is fetched from github
2. hourglass needs jailbreaking.
3. crypton-x509 no longer needs special configuration

CC @maralorn

[maralorn]

We prefer not to merge the base branch into pull requests, our git history is long enough as it is.

[maralorn]

Thank you!

I will do the hourglass fix manually, since we need it on the branch now.

The url to the hevm patch is unstable. Can you please change that to an explicit commit range? Also can you please add a comment to the upstream PR?

[maralorn]

I settled on a different fix for hourglass so you can remove your override from this PR. (after a rebase)

[maralorn]

Me again, sorry. I also applied the crypton-x509 fix on the branch, so you can also drop that. :D

[hellwolf]

We prefer not to merge the base branch into pull requests, our git history is long enough as it is.

okay, I just rebased instead.

[hellwolf]

I will do the hourglass fix manually, since we need it on the branch now.

Ack, I have removed my fix.

[hellwolf]

Me again, sorry. I also applied the crypton-x509 fix on the branch, so you can also drop that. :D

ack.

[hellwolf]

The url to the hevm patch is unstable. Can you please change that to an explicit commit range?

Yes, that makes sense. Done.

Also can you please add a comment to the upstream PR?

It doesn't have an upstream PR for this minimum patch, though. I intend to create a PR with a bigger changeset. Is that okay?

[maralorn]

The url to the hevm patch is unstable. Can you please change that to an explicit commit range?

Yes, that makes sense. Done.

Also can you please add a comment to the upstream PR?

It doesn't have an upstream PR for this minimum patch, though. I intend to create a PR with a bigger changeset. Is that okay?

Sure.

[maralorn]

Suggested change

	postPatch = old.pstPatch or "" + ''
	postPatch = old.postPatch or "" + ''

[hellwolf]

fixed