-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
kakoune-lsp: 16.0.0 -> 17.1.1 #302761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
kakoune-lsp: 16.0.0 -> 17.1.1 #302761
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| From 17cec4d94bc04bd02b91361ca72f561f1eebce60 Mon Sep 17 00:00:00 2001 | ||
| From: V <v@anomalous.eu> | ||
| Date: Tue, 9 Apr 2024 06:15:00 +0200 | ||
| Subject: [PATCH] Hardcode perl | ||
|
|
||
| --- | ||
| rc/lsp.kak | 13 ++----------- | ||
| 1 file changed, 2 insertions(+), 11 deletions(-) | ||
|
|
||
| diff --git a/rc/lsp.kak b/rc/lsp.kak | ||
| index b173478..015c3ca 100644 | ||
| --- a/rc/lsp.kak | ||
| +++ b/rc/lsp.kak | ||
| @@ -280,12 +280,8 @@ define-command -hidden lsp-menu -params 1.. %{ | ||
| } | ||
| define-command -hidden lsp-menu-impl %{ | ||
| evaluate-commands %sh{ | ||
| - if ! command -v perl > /dev/null; then | ||
| - printf "fail %{'perl' must be installed to use the 'lsp-menu' command}" | ||
| - exit | ||
| - fi | ||
| echo >$kak_command_fifo "echo -to-file $kak_response_fifo -quoting kakoune -- %reg{a}" | ||
| - perl < $kak_response_fifo -we ' | ||
| + @perl@ < $kak_response_fifo -we ' | ||
| use strict; | ||
| my $Q = "'\''"; | ||
| my @args = (); | ||
| @@ -2410,11 +2406,6 @@ define-command -hidden lsp-snippets-insert-completion -params 1 %{ evaluate-comm | ||
| }} | ||
|
|
||
| define-command lsp-snippets-insert -hidden -params 1 %[ | ||
| - evaluate-commands %sh{ | ||
| - if ! command -v perl > /dev/null; then | ||
| - printf "fail %{'perl' must be installed to use the 'lsp-snippets-insert' command'}" | ||
| - fi | ||
| - } | ||
| evaluate-commands -draft -save-regs '^"' %[ | ||
| set-register '"' %arg{1} | ||
| execute-keys <a-P> | ||
| @@ -2469,7 +2460,7 @@ define-command lsp-snippets-insert -hidden -params 1 %[ | ||
| define-command -hidden lsp-snippets-insert-perl-impl %[ | ||
| set-register x nop | ||
| evaluate-commands %sh[ # $kak_quoted_selections | ||
| - perl -e ' | ||
| + @perl@ -e ' | ||
|
philiptaron marked this conversation as resolved.
Outdated
|
||
| use strict; | ||
| use warnings; | ||
| use Text::ParseWords(); | ||
| -- | ||
| 2.44.0 | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,37 @@ | ||
| { stdenv, lib, fetchFromGitHub, rustPlatform, perl, CoreServices, Security, SystemConfiguration }: | ||
| { lib | ||
| , rustPlatform | ||
| , fetchFromGitHub | ||
| , substituteAll, perl | ||
| , stdenv, CoreServices, Security, SystemConfiguration | ||
| }: | ||
|
philiptaron marked this conversation as resolved.
Outdated
|
||
|
|
||
| rustPlatform.buildRustPackage rec { | ||
| pname = "kakoune-lsp"; | ||
| version = "16.0.0"; | ||
| version = "17.0.1"; | ||
|
philiptaron marked this conversation as resolved.
Outdated
|
||
|
|
||
| src = fetchFromGitHub { | ||
| owner = pname; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| sha256 = "sha256-d4Tc6iYp20uOKMd+T2LhWgXWZzvzq1E+VWqjhhiIiHE="; | ||
| sha256 = "sha256-uXKquAjfytUn/Q0kx+0BGRQTkVMQ9rMRnTCy622upag="; | ||
| }; | ||
|
philiptaron marked this conversation as resolved.
|
||
|
|
||
| cargoHash = "sha256-kV8d0PwIWS6gyfCtv70iv8MrL91ZOZbwYznhc3lUw0U="; | ||
|
|
||
| buildInputs = [ perl ] ++ lib.optionals stdenv.isDarwin [ CoreServices Security SystemConfiguration ]; | ||
|
|
||
| patches = [ | ||
| ./Use-full-Perl-path.patch | ||
| (substituteAll { | ||
| src = ./Hardcode-perl.patch; | ||
| perl = lib.getExe perl; | ||
| }) | ||
|
philiptaron marked this conversation as resolved.
Outdated
|
||
| ]; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace rc/lsp.kak \ | ||
| --subst-var-by perlPath ${lib.getBin perl} | ||
| ''; | ||
| cargoHash = "sha256-XnhYODMzqInwbgM8wveY048sljZ8OKw4hLYJG5h8Twc="; | ||
|
|
||
| buildInputs = lib.optionals stdenv.isDarwin [ CoreServices Security SystemConfiguration ]; | ||
|
|
||
| meta = with lib; { | ||
| meta = { | ||
| description = "Kakoune Language Server Protocol Client"; | ||
| homepage = "https://github.com/kakoune-lsp/kakoune-lsp"; | ||
| license = with licenses; [ unlicense /* or */ mit ]; | ||
| maintainers = with maintainers; [ philiptaron spacekookie poweredbypie ]; | ||
| license = with lib.licenses; [ unlicense /* or */ mit ]; | ||
| maintainers = with lib.maintainers; [ philiptaron spacekookie poweredbypie ]; | ||
| mainProgram = "kak-lsp"; | ||
| }; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.