cuda-modules: rewrite setup hooks#302694
Draft
ConnorBaker wants to merge 6 commits intoNixOS:masterfrom
Draft
Conversation
17 tasks
516dbd1 to
89e03ed
Compare
89e03ed to
949e77e
Compare
Contributor
Author
|
@SomeoneSerge of some interest -- we're not in the global scope in the body of these setup hooks, I believe. I was running into errors when trying to use the associative arrays |
ff997bd to
0d2e942
Compare
added 5 commits
April 19, 2024 15:46
0d2e942 to
d0efe91
Compare
Comment on lines
+17
to
+20
| markForCudatoolkitRootHook = | ||
| mkRenamed "markForCudatoolkitRootHook" "cudaPackages.markForCudatoolkitRoot" | ||
| final.markForCudatoolkitRoot; # Added 2024-04-19 | ||
| setupCudaHook = mkRenamed "setupCudaHook" "cudaPackages.setupCuda" final.setupCuda; # Added 2024-04-19 |
Contributor
There was a problem hiding this comment.
I remember a discussion about this, and I agree there's little point in having the suffix, and it's ok not to have it... I don't know why bother renaming old stuff, but no strong opinions here on my part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
To-do:
Description of changes
markForCudatoolkitRootandsetupCudato make use of new logging utility and do general cleanupThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.