Skip to content

Comments

mozillavpn: add qtwayland to build inputs#301290

Merged
wegank merged 1 commit intoNixOS:masterfrom
teutat3s:mozillavpn-fix-wayland
Apr 4, 2024
Merged

mozillavpn: add qtwayland to build inputs#301290
wegank merged 1 commit intoNixOS:masterfrom
teutat3s:mozillavpn-fix-wayland

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Apr 3, 2024

Description of changes

This fixes the app not launching in a wayland environment.

❯ env | grep '^QT_'
QT_QPA_PLATFORMTHEME=gtk2
QT_STYLE_OVERRIDE=gtk2
QT_QPA_PLATFORM=wayland
...

❯ mozillavpn
Aborted (core dumped)

~/.local/share/mozillavpn.log showed:

Warning: Could not find the Qt platform plugin "wayland" in ""
Error: This application failed to start because no Qt platform plugin could be initialized. 
Reinstalling the application may fix this problem. 
Available platform plugins are: linuxfb, minimal, eglfs, minimalegl, vkkhrdisplay, xcb, vnc, offscreen.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This fixes the app not launching in a wayland environment.
❯ mozillavpn
Aborted (core dumped)

~/.local/share/mozillavpn.log showed:
Warning: Could not find the Qt platform plugin "wayland" in ""
Error: This application failed to start because no Qt platform plugin could be initialized.
Reinstalling the application may fix this problem.
Available platform plugins are: linuxfb, minimal, eglfs, minimalegl, vkkhrdisplay, xcb, vnc, offscreen.
@ofborg ofborg bot requested a review from andersk April 3, 2024 17:22
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 3, 2024
Copy link
Contributor

@andersk andersk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not opposed, although it would be better to address this for all Qt apps at once rather than piecemeal:

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 3, 2024
@wegank
Copy link
Member

wegank commented Apr 4, 2024

That probably won't happen soon, as a lot of Qt apps are CLI-only and don't require Xorg or Wayland libraries.

@wegank wegank merged commit 46abcd4 into NixOS:master Apr 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Successfully created backport PR for release-23.11:

@teutat3s teutat3s deleted the mozillavpn-fix-wayland branch April 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants