puddletag: fix for pyparsing 3.1.2#300887
Merged
wegank merged 1 commit intoNixOS:masterfrom Apr 5, 2024
Merged
Conversation
ofborg
bot
added
11.by: package-maintainer
dschrempf
approved these changes
Apr 2, 2024
Comment on lines
+42
to
+45
| buildInputs = [ | ||
| qtbase | ||
| qtwayland | ||
| ]; |
Contributor
There was a problem hiding this comment.
Why do we need these now? I think we should have always included qtbase, but qtwayland?
wegank
added
12.approvals: 1
Member
Author
|
Running puddletag in a plasma wayland environment shows this:
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
Adding qtwayland makes the message disappear.
|
Contributor
|
For reference, I found:
The Nixpkgs manual (first link) actually says we should only activate |
Member
Definitely, but it's OK for this package, where |
Member
Author
|
Any remaining concerns @dschrempf ? |
Contributor
|
No! I just tried it out, and it works here. I advice merging this soon; see #301857. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Make it work with pyparsing 3.1.2 ref puddletag/puddletag#884
Also:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.