fontbakery: fix build failures#300400
Conversation
This package was failing to build because of some missing dependencies. Upstream added a new dependency on PyYAML in v0.4.1: googlefonts/shaperglot@94a9b30 and switched from poetry to setuptools in v0.4.2: googlefonts/shaperglot@2c76ffa
github-actions
bot
added
the
6.topic: python
mweinelt
left a comment
mweinelt
left a comment
There was a problem hiding this comment.
A few changes, that should be done across all packages touched.
There was a problem hiding this comment.
If you want to leak this into the environment, change it to
| gitTag = "v2024.02.05"; | |
| env.gitTag = "v2024.02.05"; |
Otherwise, I don't see any usage, please remove it.
There was a problem hiding this comment.
It's used below in meta.changelog:
changelog = "https://github.com/googlefonts/nam-files/releases/tag/${gitTag}";
Unfortunately because of upstream's chosen versioning scheme, the git tag and PyPI versions don't match. I didn't want to try and craft some complicated expression to predict the git tag from the PyPI version or vice versa, I was intending to just use this variable here as a reminder to keep these two versions in sync with each other in future.
Admittedly, that means the normal Python package update script won't work correctly on this package. I'm not sure what the best solution is in this case.
Given that the release notes on Github contain very little useful information, maybe the simplest option is to just leave meta.changelog unspecified?
ofborg
bot
added
8.has: package (new)
|
Result of 4 packages failed to build:
16 packages built:
|
This reverts commit 8566364. The 5.0.4 release was not a real release, it was a typo for 0.5.4 and has since been yanked from PyPI.
The patch is no longer needed because upstream relaxed the version range.
Upstream started depending on gflanguages and requests from v0.6.12: googlefonts/glyphsets@ba341dc googlefonts/glyphsets@8ca303d
This patch no longer applies cleanly, and upstream has already completely refactored everything since the v0.11.2 release so my updated PR won't apply cleanly either. Just explicitly skip all tests requiring network access for now. Hopefully in a later release, this list of tests to skip can be shortened or removed.
|
Thanks for the review. I've amended this PR to use |
|
Just for the record, the build failures reported by |
2 participants
Description of changes
The bulk update of Python packages in PR #294305 introduced build failures in fontbakery and several of its dependencies. This fixes the whole chain to get fontbakery building again.
Things done
For non-Linux: Is sandboxing enabled innix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.