python312Packages.periodiq: Relax pendulum dependency#300086
Merged
leona-ya merged 1 commit intoNixOS:masterfrom Apr 18, 2024
Merged
python312Packages.periodiq: Relax pendulum dependency#300086leona-ya merged 1 commit intoNixOS:masterfrom
leona-ya merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
Contributor
Author
|
Result of 10 packages built:
|
ofborg
bot
added
11.by: package-maintainer
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3786 |
sarahec
suggested changes
Apr 14, 2024
sarahec
reviewed
Apr 14, 2024
Contributor
sarahec
left a comment
sarahec
left a comment
There was a problem hiding this comment.
All Python tests pass. nixpkgs-review passes.
leona-ya
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Due to a pendulum update the perodiq build broke. The package still works while relaxing the dependency
Broken by #294305
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.