[staging] coreutils: 9.4 -> 9.5#299945
Merged
LeSuisse merged 1 commit intoNixOS:stagingfrom Apr 7, 2024
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ccb78aa to
ce914ba
Compare
Contributor
|
About |
Member
Announcement with changelog: https://lists.gnu.org/archive/html/info-gnu/2024-03/msg00006.html
ivan
approved these changes
Apr 1, 2024
Member
ivan
left a comment
There was a problem hiding this comment.
I rebuilt my NixOS x86_64 staging-next machines with this PR and didn't encounter issues.
lucasew
approved these changes
Apr 1, 2024
Contributor
|
Is there a reason this hasn't been merged? |
LeSuisse
approved these changes
Apr 7, 2024
Member
LeSuisse
left a comment
There was a problem hiding this comment.
I'm not aware of a specific reason, anyway I have also been able able to rebuild one of my Linux x86_64 box with this change with no issue so let's merge.
Member
|
A test got broken with musl? |
Member
|
I confirm the issue, I thought I had built that before merging 🤔 Anyway it is a known upstream bug, see #304856 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Announcement and changelog: https://lists.gnu.org/archive/html/info-gnu/2024-03/msg00006.html
Things that are worth mentioning:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.