Skip to content

[staging] coreutils: 9.4 -> 9.5#299945

Merged
LeSuisse merged 1 commit intoNixOS:stagingfrom
helsinki-systems:upd/coreutils
Apr 7, 2024
Merged

[staging] coreutils: 9.4 -> 9.5#299945
LeSuisse merged 1 commit intoNixOS:stagingfrom
helsinki-systems:upd/coreutils

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Mar 29, 2024

Description of changes

Announcement and changelog: https://lists.gnu.org/archive/html/info-gnu/2024-03/msg00006.html

Things that are worth mentioning:

  • cp --no-clobber, and mv -n no longer exit with failure status if existing files are encountered in the destination
  • chgrp now accepts the --from=OWNER:GROUP option to restrict changes to files with matching current OWNER and/or GROUP, as already supported by chown(1).
  • cp,mv,install,cat,split now read and write a minimum of 256KiB at a time. This was previously 128KiB and increasing to 256KiB was seen to increase throughput by 10-20% when reading cached files on modern systems.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dasJ

This comment was marked as outdated.

@dasJ dasJ force-pushed the upd/coreutils branch 2 times, most recently from ccb78aa to ce914ba Compare March 29, 2024 09:46
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 29, 2024
@AndersonTorres AndersonTorres requested a review from lucasew March 29, 2024 11:51
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 29, 2024
@lucasew
Copy link
Contributor

lucasew commented Mar 29, 2024

About advcpmv that depends on this:

advcpmv> Coreutils version does not match advcpmv version!
advcpmv> advcpmv-data needs to be updated to support coreutils 9.5

@LeSuisse
Copy link
Member

Fixes CVE-2024-0684.

https://www.openwall.com/lists/oss-security/2024/01/18/2

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 30, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 30, 2024
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt my NixOS x86_64 staging-next machines with this PR and didn't encounter issues.

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Apr 1, 2024
@risicle
Copy link
Contributor

risicle commented Apr 7, 2024

Is there a reason this hasn't been merged?

Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of a specific reason, anyway I have also been able able to rebuild one of my Linux x86_64 box with this change with no issue so let's merge.

@LeSuisse LeSuisse merged commit cea802f into NixOS:staging Apr 7, 2024
@vcunat
Copy link
Member

vcunat commented Apr 17, 2024

A test got broken with musl?

../build-aux/test-driver: line 112: 111212 Aborted                 (core dumped) "$@" >> "$log_file" 2>&1
FAIL: test-canonicalize

@LeSuisse
Copy link
Member

I confirm the issue, I thought I had built that before merging 🤔

Anyway it is a known upstream bug, see #304856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants