element-desktop: 1.11.61 -> 1.11.63#299820
Merged
yu-re-ka merged 1 commit intoNixOS:masterfrom Apr 1, 2024
Merged
Conversation
ofborg
bot
requested review from
D4ndellion,
Ma27,
NickCao,
Ralith,
mguentner and
sumnerevans
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
iFreilicht
approved these changes
Mar 28, 2024
Contributor
iFreilicht
left a comment
iFreilicht
left a comment
There was a problem hiding this comment.
Tried to build with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 299820" first, but that built element-web instead (though successfully).
Instead, nix build .#element-desktop && ./result/bin/element-desktop worked as expected on aarch64-darwin. I tested the app and was able to sign in and send messages 👍
@yu-re-ka element-desktop.nix uses electron, which is already version 29.1.4. So I'd say there's nothing to be done regarding that, right?
Contributor
|
It is pinned to electron_28 in all-packages.nix
28 Mar 2024 23:41:19 Felix Uhl ***@***.***>:
…
***@***.**** approved this pull request.
Tried to build with *nix-shell -p nixpkgs-review --run "nixpkgs-review pr 299820"* first, but that built *element-web* instead (though successfully).
Instead, *nix build .#element-desktop && ./result/bin/element-desktop* worked as expected on aarch64-darwin. I tested the app and was able to sign in and send messages 👍
@yu-re-ka[https://github.com/yu-re-ka] *element-desktop.nix* uses *electron*, which is already version 29.1.4. So I'd say there's nothing to be done regarding that, right?
—
Reply to this email directly, view it on GitHub[#299820 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AURNSZINWJNK4VJANDDPEITY2SE75AVCNFSM6AAAAABFNMY2XCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRXGQ4DEOJTGA].
You are receiving this because you were mentioned.
[Tracking image][https://github.com/notifications/beacon/AURNSZKMLE2SABW6DR72J5DY2SE75A5CNFSM6AAAAABFNMY2XCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTVIVUDE.gif]
|
wegank
added
the
12.approvals: 1
element-desktop: use electron_29, following upstream: element-hq/element-desktop@525d633
teutat3s
force-pushed
the
element-desktop-1.11.63
branch
from
f7d9ab2 to
da74f72
Compare
Member
Author
|
Good catch, thanks. Done. |
wegank
removed
the
12.approvals: 1
SebTM
added
12.approvals: 2
wegank
added
12.approvals: 2
Member
|
Result of 2 packages built:
|
wegank
approved these changes
Apr 1, 2024
wegank
added
12.approvals: 3+
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/element-hq/element-desktop/releases/tag/v1.11.62
https://github.com/element-hq/element-desktop/releases/tag/v1.11.63
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.