Skip to content

Comments

mousecape: move to by-name/mo#299537

Merged
1 commit merged intoNixOS:masterfrom
FlameFlag:move-mousecape
Mar 27, 2024
Merged

mousecape: move to by-name/mo#299537
1 commit merged intoNixOS:masterfrom
FlameFlag:move-mousecape

Conversation

@FlameFlag
Copy link
Member

Description of changes

  • Previously package resided in darwin/mousecape due to confusion, this breaks the pkgs category hierarchy as mentioned by mousecape: init at 1813 #299032 (comment)
  • Also switched to using fetchzip
  • Fixed maintainer name

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- Previously package resided in darwin/mousecape due to confusion, this
  breaks the pkgs category hierarchy as mentioned by
  NixOS#299032 (comment)
- Also switched to using fetchzip
- Fixed maintainer name
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@stepbrobd
Copy link
Member

Result of nixpkgs-review pr 299537 run on aarch64-darwin 1

1 package built:
  • mousecape

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Mar 27, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 27, 2024
@ghost ghost merged commit 893bfe0 into NixOS:master Mar 27, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@FlameFlag FlameFlag deleted the move-mousecape branch May 5, 2024 17:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants