darwin: add darwin-aliases.nix#299360
Merged
reckenrode merged 2 commits intoNixOS:masterfrom Mar 27, 2024
Merged
Conversation
Contributor
Author
|
If I did this right, there shouldn’t be any rebuilds. |
919359b to
8018673
Compare
Contributor
Author
|
I dropped the MoltenVK move. I’ll do it as part of the 1.2.8 update once this is merged (or post update depending on timing). It was causing the |
ghost
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
LGTM.
testing:
- added alias with a throw and it threw
- added alias to another package and got other package
- ran meta checks locally and validated that the aliases were not used.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Darwin needs a way to deprecate and move packages in the
darwinscope. This is needed to support transitioning to upstream packages for libiconv and icu. It’s also useful for moving things out ofdarwintoby-name.This PR also moves two packages to darwin-aliases.nix:
moltenvk (moved toby-name)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.