Skip to content

steampipePackages.steampipe-plugins-aws: init at 0.132.0#299274

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
anthonyroussel:steampipe-plugin-aws
Aug 1, 2024
Merged

steampipePackages.steampipe-plugins-aws: init at 0.132.0#299274
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
anthonyroussel:steampipe-plugin-aws

Conversation

@anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Mar 26, 2024

Description of changes

steampipePackages.steampipe-postgres-fdw is also coming, but looks like it is very difficult to compile and package with PostgreSQL. Maybe it could be a resolution to #215945

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 26, 2024
@anthonyroussel
Copy link
Member Author

anthonyroussel commented Mar 26, 2024

@ofborg build steampipePackages

@anthonyroussel anthonyroussel force-pushed the steampipe-plugin-aws branch 3 times, most recently from d0d7ed2 to b10672e Compare March 26, 2024 19:52
@ofborg ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 26, 2024
@weitzj
Copy link

weitzj commented May 17, 2024

@anthonyroussel I would love to help you approve this. Can I do anything? Add myself to maintainers?

@weitzj
Copy link

weitzj commented May 19, 2024

Result of nixpkgs-review pr 299274 run on aarch64-linux 1

1 package failed to build:
  • steampipePackages.steampipe-plugin-aws
1 package built:
  • steampipePackages.steampipe-plugin-github

2 similar comments
@weitzj
Copy link

weitzj commented May 19, 2024

Result of nixpkgs-review pr 299274 run on aarch64-linux 1

1 package failed to build:
  • steampipePackages.steampipe-plugin-aws
1 package built:
  • steampipePackages.steampipe-plugin-github

@weitzj
Copy link

weitzj commented May 19, 2024

Result of nixpkgs-review pr 299274 run on aarch64-linux 1

1 package failed to build:
  • steampipePackages.steampipe-plugin-aws
1 package built:
  • steampipePackages.steampipe-plugin-github

@anthonyroussel anthonyroussel force-pushed the steampipe-plugin-aws branch from b10672e to 090e8a8 Compare May 21, 2024 18:28
@anthonyroussel
Copy link
Member Author

Rebased against master branch, and updated aws plugin to 0.138, github plugin to 0.41.0

@anthonyroussel
Copy link
Member Author

Result of nixpkgs-review pr 299274 run on aarch64-linux 1

1 package failed to build:

  • steampipePackages.steampipe-plugin-aws

1 package built:

  • steampipePackages.steampipe-plugin-github

@weitzj Hello, thanks for the review!

It looks like the build of the steampipePackages.steampipe-plugin-aws package failed on your machine from the nixpkgs-review output you posted.

Did you get any errors when building this package?

@anthonyroussel
Copy link
Member Author

anthonyroussel commented May 21, 2024

@ofborg build steampipePackages

@weitzj
Copy link

weitzj commented May 22, 2024

I will check again tonight or the next says

@weitzj
Copy link

weitzj commented May 30, 2024

Result of nixpkgs-review pr 299274 run on aarch64-linux 1

2 packages built:
  • steampipePackages.steampipe-plugin-aws
  • steampipePackages.steampipe-plugin-github

@weitzj
Copy link

weitzj commented May 30, 2024

Looks good @anthonyroussel

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1713

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1764

@SuperSandro2000 SuperSandro2000 merged commit 5263b5b into NixOS:master Aug 1, 2024
@anthonyroussel anthonyroussel deleted the steampipe-plugin-aws branch August 1, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments