steampipePackages.steampipe-plugins-aws: init at 0.132.0#299274
steampipePackages.steampipe-plugins-aws: init at 0.132.0#299274SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Conversation
|
@ofborg build steampipePackages |
0399d2d to
852681f
Compare
d0d7ed2 to
b10672e
Compare
|
@anthonyroussel I would love to help you approve this. Can I do anything? Add myself to maintainers? |
|
Result of 1 package failed to build:
1 package built:
|
2 similar comments
|
Result of 1 package failed to build:
1 package built:
|
|
Result of 1 package failed to build:
1 package built:
|
b10672e to
090e8a8
Compare
|
Rebased against master branch, and updated aws plugin to 0.138, github plugin to 0.41.0 |
@weitzj Hello, thanks for the review! It looks like the build of the Did you get any errors when building this package? |
|
@ofborg build steampipePackages |
|
I will check again tonight or the next says |
|
Result of 2 packages built:
|
|
Looks good @anthonyroussel |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1713 |
pkgs/tools/misc/steampipe-packages/steampipe-plugin-aws/default.nix
Outdated
Show resolved
Hide resolved
pkgs/tools/misc/steampipe-packages/steampipe-plugin-github/default.nix
Outdated
Show resolved
Hide resolved
090e8a8 to
d9e0c50
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1764 |
Description of changes
steampipePackages.steampipe-postgres-fdw is also coming, but looks like it is very difficult to compile and package with PostgreSQL. Maybe it could be a resolution to #215945
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.