Merged
Conversation
sikmir
reviewed
Mar 22, 2024
Member
Author
|
The new push just now utilized the #305484 may change the situation a bit, too, because this package is using gi-crystal. In #305484 (comment), I was hoping we can have a better way of packaging Crystal packages that use gi-crystal. CC @sund3RRR. |
AndersonTorres
suggested changes
Jun 29, 2024
FliegendeWurst
requested changes
Nov 13, 2024
FliegendeWurst
approved these changes
Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds package AHK_X11, an AutoHotkey implementation for Linux.
Closes #279323.
Closes #297972 (this PR contains the commit in that PR)(already merged). CC @AndersonTorres.It reports command not found for(Fixed in upstream).filecommand if your PATH does not contain that command. This error does not affect normal usage. I could have fixed by addingfileas a dependency, but this is actually a non-fatal upstream bug (phil294/AHK_X11#75), so I left it like thisAHK_X11 from this package does not have functionality of compiling scripts into portable executable. The implementation of that compilation feature is simply to concatenate the binary and the script to form an executable file, but executable files in NixOS are not executable in other systems. I was thinking packaging a
ahk_x11-binpackage for that demand, but I didn't do that because the executable cannot run in the environment where it was built (even withsteam-rundue to the requirement oflibnotify).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.