Skip to content

python3Packages.catppuccin: 2.1.0 -> 1.3.2#297683

Merged
wegank merged 1 commit intoNixOS:masterfrom
TomaSajt:catppuccin-python-downgrade
Mar 21, 2024
Merged

python3Packages.catppuccin: 2.1.0 -> 1.3.2#297683
wegank merged 1 commit intoNixOS:masterfrom
TomaSajt:catppuccin-python-downgrade

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Mar 21, 2024

Description of changes

This PR reverts the version bump done by #294305 for the catppuccin python package.

catppuccin-gtk depends on this package, and sadly, it doesn't yet support the newer version of the python package. I believe it's more important to have catppuccin-gtk working than to have an up-to-date package.

I also added some comments about the next version bump being synced with catpuccin-gtk

Related discussion: #290391

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 21, 2024
@ofborg ofborg bot requested a review from fufexan March 21, 2024 10:35
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 21, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 21, 2024
@wegank wegank merged commit 8c58e99 into NixOS:master Mar 21, 2024
@TomaSajt TomaSajt deleted the catppuccin-python-downgrade branch March 21, 2024 12:11
@jonathan-conder
Copy link
Contributor

Just FYI catppuccin/gtk#159 has been merged so this can probably be re-upgraded when catppuccin-gtk makes a new release

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Apr 3, 2024

Updated my old PR to also update catppuccin-gtk and use fetchpatch for the fix
PR: #290391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants